Skip to content

Add API resource access to notification sender v2 API #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

Add API resource access to notification sender v2 API #6657

merged 2 commits into from
Apr 21, 2025

Conversation

lashinijay
Copy link
Contributor

@lashinijay lashinijay commented Apr 1, 2025 •
edited
Loading

Proposed changes in this pull request

$subject

Related Issue

@ThaminduR
Copy link
Contributor

Update the xml file as well

@lashinijay lashinijay force-pushed the add-resource-access-control-notification-sender-v2 branch from 50dd15c to 29f4a4b Compare April 21, 2025 09:32
ThaminduR
ThaminduR previously approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@ThaminduR ThaminduR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will enable the v2 API endpoints while continuing to use the existing internal_notification_senders_ scopes.

However, one thing to note is that the API resource representation will still only reflect the v1 version. This means that anyone intending to consume the v2 API will still need to authorize the v1 API in their application in order to obtain the necessary scopes.

@codecov Codecov
Copy link

codecov bot commented Apr 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.34%. Comparing base (55caab6) to head (40c24e9).
Report is 104 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6657      +/-   ##
============================================
+ Coverage     47.59%   48.34%   +0.74%     
- Complexity    16454    16510      +56     
============================================
  Files          1830     1833       +3     
  Lines        114308   112403    -1905     
  Branches      21642    21583      -59     
============================================
- Hits          54409    54340      -69     
+ Misses        52447    50702    -1745     
+ Partials       7452     7361      -91
Flag Coverage Δ
unit 32.06% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lashinijay lashinijay force-pushed the add-resource-access-control-notification-sender-v2 branch from 1b157e6 to 40c24e9 Compare April 21, 2025 11:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lashinijay lashinijay merged commit b491b41 into wso2:master Apr 21, 2025
5 checks passed
Avarjana pushed a commit to Avarjana/carbon-identity-framework that referenced this pull request Apr 24, 2025
@lashinijay @Avarjana
Add API resource access to notification sender v2 API (wso2#6657)
1b19253 
* Add API resource access to notification sender v2 API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThaminduR ThaminduR ThaminduR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lashinijay @ThaminduR